| From: | Christoph Berg <myon(at)debian(dot)org> |
|---|---|
| To: | Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] pg_filedump is broken |
| Date: | 2016-10-14 09:32:01 |
| Message-ID: | 20161014093201.zwu2nu4bl6nqpnie@msg.df7cb.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Re: Aleksander Alekseev 2016-10-12 <20161012111527(dot)GA17916(at)e733(dot)localdomain>
> Hello.
>
> First patch fixes:
>
> ```
> pg_filedump.c: In function ‘FormatItem’:
> pg_filedump.c:994:18: error: ‘SizeOfIptrData’ undeclared (first use in
> this function)
> if (numBytes < SizeOfIptrData)
> ```
>
> After 8023b582 there is no more SizeOfIptrData macro.
Thanks, pushed to filedump git.
> Second patch fixes Makefile. On some systems (notably FreeBSD) there is
> no `gcc` by default. Using `cc` is a more crossplatform way to compile a
> project.
I think we just shouldn't set CC at all. Pushed along with some more
usage of pg_config.
Christoph
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christoph Berg | 2016-10-14 09:34:42 | Re: [PATCH] pg_filedump is broken |
| Previous Message | Heikki Linnakangas | 2016-10-14 08:53:46 | Re: PL/Python adding support for multi-dimensional arrays |