From: | Michael Banck <michael(dot)banck(at)credativ(dot)de> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Subject: | pg_rewind: Should abort if both --source-pgdata and --source-server are specified |
Date: | 2016-10-07 10:34:14 |
Message-ID: | 20161007103414.GD12247@nighthawk.caipicrew.dd-dns.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
ISTM that pg_rewind's --source-pgdata and --source-server options are
mutually exclusive, and the synopsis in the documentation seems to
indicate that as well:
|pg_rewind [option...] {-D | --target-pgdata} directory
|{--source-pgdata=directory | --source-server=connstr}
However, there is no such check in the code.
I've seen people assume --source-pgdata is supposed to be the data
directory location on the remote server if they specify --source-server
as well, and are then confused by error messages.
So I think pg_rewind should abort in this case. Patch for that attached.
Thoughts?
Michael
--
Michael Banck
Projektleiter / Senior Berater
Tel.: +49 2166 9901-171
Fax: +49 2166 9901-100
Email: michael(dot)banck(at)credativ(dot)de
credativ GmbH, HRB Mönchengladbach 12080
USt-ID-Nummer: DE204566209
Trompeterallee 108, 41189 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer
Attachment | Content-Type | Size |
---|---|---|
pg_rewind.patch | text/x-diff | 635 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2016-10-07 10:46:31 | Re: Radix tree for character conversion |
Previous Message | Julien Rouhaud | 2016-10-07 09:39:38 | pg_stat_statements and non default search_path |