From: | Victor Wagner <vitus(at)wagner(dot)pp(dot)ru> |
---|---|
To: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [PATCH] Generic type subscription |
Date: | 2016-10-04 08:28:42 |
Message-ID: | 20161004112842.01d8e045@fafnir.local.vm |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, 1 Oct 2016 16:52:34 +0700
Dmitry Dolgov <9erthalion6(at)gmail(dot)com> wrote:
> > I've tried to compile this patch with current state of master
> > (commit 51c3e9fade76c12) and found out that, when configured with
> --enable-cassert,
> > it doesn't pass make check.
>
> Thanks for the feedback. Yes, unexpectedly for me, `ExecEvalExpr` can
> return expanded `jbvArray` and `jbvObject` instead `jbvBinary` in
> both cases. It's interesting, that this doesn't break anything, but
> obviously violates the `pushJsonbValueScalar` semantics. I don't
> think `ExecEvalExpr` should be changed for jsonb, we can handle this
> situation in `pushJsonbValue` instead. I've
> attached a new version of patch with this modification.
Thanks for you quick responce. I've not yet thoroughly investigated new
patch, but already noticed some minor promlems:
Git complains about whitespace in this version of patch:
$ git apply ../generic_type_subscription_v2.patch
../generic_type_subscription_v2.patch:218: tab in indent.
int first;
../generic_type_subscription_v2.patch:219: tab in indent.
int second;
../generic_type_subscription_v2.patch:225: tab in indent.
SubscriptionExecData *sbsdata = (SubscriptionExecData *) PG_GETARG_POINTER(1);
../generic_type_subscription_v2.patch:226: tab in indent.
Custom *result = (Custom *) sbsdata->containerSource;
../generic_type_subscription_v2.patch:234: tab in indent.
SubscriptionRef *sbsref = (SubscriptionRef *) PG_GETARG_POINTER(0);
warning: squelched 29 whitespace errors
warning: 34 lines add whitespace errors.
It doesn't prevent me from further testing of patch, but worth noticing.
--
Victor
From | Date | Subject | |
---|---|---|---|
Next Message | Craig Ringer | 2016-10-04 08:38:48 | Re: PATCH: Batch/pipelining support for libpq |
Previous Message | Heikki Linnakangas | 2016-10-04 08:15:27 | Re: multivariate statistics (v19) |