Re: compiler warning read_objtype_from_string()

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: compiler warning read_objtype_from_string()
Date: 2016-09-28 22:09:53
Message-ID: 20160928220953.GA369472@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:

> I do not think you should assume that the compiler is smart enough to
> deduce that, nor that all compilers even know ereport(ERROR) doesn't
> return. Personally I don't see the point of the "type" variable at
> all, anyway. I would have written this as
>
> [code]

Makes sense. I will patch it that way.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2016-09-28 22:12:11 Re: PoC: Make it possible to disallow WHERE-less UPDATE and DELETE
Previous Message Alvaro Herrera 2016-09-28 22:07:00 Re: Set log_line_prefix and application name in test drivers