| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pageinspect: Hash index support |
| Date: | 2016-09-27 04:00:05 |
| Message-ID: | 20160927040005.GA294546@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut wrote:
> On 9/26/16 1:39 PM, Jesper Pedersen wrote:
> >> - hash_metap result fields spares and mapp should be arrays of integer.
> >
> > B-tree and BRIN uses a 'text' field as output, so left as is.
>
> These fields are specific to hash, so the precedent doesn't necessarily
> apply.
>
> >> - The data field could be of type bytea.
> >
> > Left as is, for same reasons as 'spares' and 'mapp'.
>
> Comments from others here? Why not use bytea instead of text?
The BRIN pageinspect functions aren't a particularly well thought-out
precedent IMO. There was practically no review of that part of the BRIN
patch, and I just threw it together in the way that seemed to make the
most sense at the time. If there's some reason why some other way is
better for hash indexes, that should be followed rather than mimicking
BRIN.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2016-09-27 04:33:25 | Re: Push down more full joins in postgres_fdw |
| Previous Message | Craig Ringer | 2016-09-27 03:53:06 | Re: patch: function xmltable |