Re: CVE-2016-1238 fix breaks (at least) pg_rewind tests

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: CVE-2016-1238 fix breaks (at least) pg_rewind tests
Date: 2016-09-08 20:58:03
Message-ID: 20160908205803.GA60492@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund wrote:

> ISTM that the easiest fix is to just tack -I '$(srcdir)' into the prove
> flags like:
> PROVE = @PROVE@
> PG_PROVE_FLAGS = -I $(top_srcdir)/src/test/perl/ -I '$(srcdir)'
> PROVE_FLAGS = --verbose
>
> I don't think there's any security concerns for us here.

Maybe not, but we could just as well use -I$(top_srcdir)/src/test/perl
and not have to think about it.

But we have other .pm's ... are there other things that would break once
the fix for that problem propagates? I think the msvc stuff will break,
for one.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2016-09-08 21:04:40 Re: CVE-2016-1238 fix breaks (at least) pg_rewind tests
Previous Message Andres Freund 2016-09-08 20:45:29 CVE-2016-1238 fix breaks (at least) pg_rewind tests