| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | amborodin(at)acm(dot)org, Andrew Borodin <borodin(at)octonica(dot)com>, Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Oleg Bartunov <obartunov(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Sergey Mirvoda <sergey(at)mirvoda(dot)com> |
| Subject: | Re: Re: GiST optimizing memmoves in gistplacetopage for fixed-size updates [PoC] |
| Date: | 2016-09-08 19:13:12 |
| Message-ID: | 20160908191312.GA52845@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Andrew Borodin <borodin(at)octonica(dot)com> writes:
> > Thank you for your corrections.
> > Here is the patch with suggestions taken into account, except 6th.
>
> I'll pick this up, unless some other committer is already on it.
>
> I think that we should buy back the addition of PageIndexTupleOverwrite
> to bufpage.c by getting rid of PageIndexDeleteNoCompact, as suggested
> earlier by Alvaro. The latter seems a lot messier in concept, and it's
> more general than BRIN needs.
Yeah, BRIN only wants to remove one item nowadays; that function was
written when the BRIN code wanted to remove multiple items in one go.
> It also kinda looks like we could get rid of PAI_ALLOW_FAR_OFFSET,
> which is a messy kluge in itself.
That'd be nice.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Adam Brightwell | 2016-09-08 19:13:54 | COPY command with RLS bug |
| Previous Message | Jeff Janes | 2016-09-08 19:09:53 | Re: Write Ahead Logging for Hash Indexes |