| From: | Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <rhaas(at)postgresql(dot)org> |
| Subject: | Re: Yet another small patch - reorderbuffer.c:1099 |
| Date: | 2016-09-05 09:03:45 |
| Message-ID: | 20160905090345.GC8871@e733 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> I looked at this and can see some of the argument on both sides, but
> if it's setting off static-analyzer warnings for some people, that
> seems like a sufficient reason to change it. We certainly make more
> significant changes than this in order to silence warnings.
>
> I rewrote the comment a bit more and pushed it.
Tom, thank you for committing this patch. And thanks everyone for your
contribution!
--
Best regards,
Aleksander Alekseev
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Antonin Houska | 2016-09-05 09:26:39 | Unused function arguments |
| Previous Message | Simon Riggs | 2016-09-05 08:52:19 | Re: Logical decoding slots can go backwards when used from SQL, docs are wrong |