Re: Renaming of pg_xlog and pg_clog

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Euler Taveira <euler(at)timbira(dot)com(dot)br>, Devrim Gündüz <devrim(at)gunduz(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Renaming of pg_xlog and pg_clog
Date: 2016-08-26 14:50:33
Message-ID: 20160826145033.GP4028@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

* Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> Euler Taveira <euler(at)timbira(dot)com(dot)br> writes:
> > On 26-08-2016 09:25, Devrim Gündüz wrote:
> >> ...and we also have "pg_logical", that includes a "log" keyword already...
>
> > "clog" and "xlog" is almost "log"; "logical" is not. I don't imagine
> > people confusing "logical" meaning "log".
>
> Well, I dunno; people with a weak grasp of English might have an issue
> there. But I never liked that directory name anyway; my problem with
> it is I read "pg_logical" and think "logical what?". Naming things using
> a disconnected adjective is not good, especially one with as many
> potential applications as that one has. If we're up for renaming things
> under PGDATA, that one is high on my hit list.

iirc, pg_logical also has both temporary and non-temporary data in it
too. That complicates things for backup utilities that are trying to
exclude all temporary files. If we actually move all the temp files
into their own directory (or tree), then we're changing what's in
pg_logical anyway, so renaming it seems like a good idea.

Thanks!

Stephen

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2016-08-26 15:04:16 Re: PG_DIAG_SEVERITY and a possible bug in pq_parse_errornotice()
Previous Message Tom Lane 2016-08-26 14:44:54 Re: Renaming of pg_xlog and pg_clog