Re: Column COMMENTs in CREATE TABLE?

From: David Fetter <david(at)fetter(dot)org>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Fetter <david(at)fetter(dot)org>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Marko Tiikkaja <marko(at)joh(dot)to>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Column COMMENTs in CREATE TABLE?
Date: 2016-08-05 15:58:07
Message-ID: 20160805155807.GA32377@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Aug 05, 2016 at 10:14:21AM -0400, Peter Eisentraut wrote:
> On 7/3/16 11:41 AM, Tom Lane wrote:
> > I can see the reasoning for
> > allowing COMMENT in a table column definition, but the argument for
> > allowing it in simpler CREATEs seems tissue-thin:
> >
> > CREATE FUNCTION foo(int) RETURNS ... ;
> > COMMENT ON FUNCTION foo(int) IS 'blah';
> >
> > vs
> >
> > CREATE FUNCTION foo(int) RETURNS ...
> > WITH (COMMENT 'blah');
> >
> > Not much of a keystroke savings, nor is the comment noticeably
> > "closer" to its object than before.
>
> I had actually been thinking about a similar proposal, but specifically
> for CREATE FUNCTION. But the syntax would have to put it above the
> function body, not below it. I think the CREATE FUNCTION syntax could
> actually handle that.

For what it's worth, I tend to put the function body last. That's
just my taste, though. Would it be hard to keep the ability to
permute the stuff after

CREATE FUNCTION (args)
RETURNS [SETOF] type

as we have it now?

Best,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2016-08-05 16:04:15 Re: Re: [COMMITTERS] pgsql: Prevent "snapshot too old" from trying to return pruned TOAST tu
Previous Message Robert Haas 2016-08-05 15:50:25 Re: regression test for extended query protocol