| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Increasing timeout of poll_query_until for TAP tests |
| Date: | 2016-08-03 17:34:05 |
| Message-ID: | 20160803173405.GA636698@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier wrote:
> On Wed, Aug 3, 2016 at 7:21 AM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> > Why not capture both items in a single select, such as in the attached
> > patch?
>
> Let me test this....
> [... A while after ...]
> This looks to work properly. 12 runs in a row have passed.
Okay, applied that way.
BTW, one-line long queries look awful in that perl code. I don't
propose to change anything now, but I propose that long queries are
split using here-docs in new code,
$node->safe_psql(<<EQ);
SELECT foo
FROM bar
EQ
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joshua Bay | 2016-08-03 17:35:52 | Re: Way to access LSN (for each transaction) by directly talking to postgres? |
| Previous Message | Andreas Seltenreich | 2016-08-03 17:29:13 | [sqlsmith] FailedAssertion("!(k == indices_count)", File: "tsvector_op.c", Line: 511) |