Re: pg_upgrade: exit_hook_registered variable

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: a(dot)zakirov(at)postgrespro(dot)ru
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_upgrade: exit_hook_registered variable
Date: 2016-07-28 10:21:00
Message-ID: 20160728.192100.59056316.horiguchi.kyotaro@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello,

> I noticed that exit_hook_registered variable in start_postmaster() is
> local variable. Shouldn't it be a static variable?
>
> I attached a patch. Thank you!

Good catch! It is totally useless unless being static.

But I think it is not necessary to go outside
start_postmaster. Just being static staying in start_postmaster
is enough.

regards,

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
0001-start_postmaster-of-pg_upgarde-registers-exit-functi.patch text/x-patch 1004 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Geoff Winkless 2016-07-28 10:58:45 Re: Why we lost Uber as a user
Previous Message Kyotaro HORIGUCHI 2016-07-28 09:52:28 Wrong defeinition of pq_putmessage_noblock since 9.5