Re: rethinking dense_alloc (HashJoin) as a memory context

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Geoghegan <pg(at)heroku(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: rethinking dense_alloc (HashJoin) as a memory context
Date: 2016-07-13 17:44:18
Message-ID: 20160713174418.sygesihmyc3upjyh@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2016-07-13 13:37:55 -0400, Tom Lane wrote:
> I wonder though if we don't already have another similar use-case in
> the ad-hoc "slab allocators" in reorderbuffer.c.

That seems to call more for a general slab allocator design, than for
something like here. After all, there's plenty of freeing ther.e

> We already know that
> that code has performance issues, cf bug #14231, so I suspect there's
> a redesign in its future anyway.

Note that it's not the slab allocators that is having problems, it's
aset.c, iterating through all allocated blocks.

Andres

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2016-07-13 17:47:17 Re: Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold <
Previous Message Tom Lane 2016-07-13 17:37:55 Re: rethinking dense_alloc (HashJoin) as a memory context