Re: [CF2016-9] Allow spaces in working path on tap-tests

Hello,

At Tue, 5 Jul 2016 13:44:08 +0900, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote in <CAB7nPqSt2W30tE12eRq7KGB_FPcBpXDX2Zh8XeH2QHFY9Vfb8Q(at)mail(dot)gmail(dot)com>
> On Mon, Jul 4, 2016 at 4:44 PM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
> > And as is the command built for zic.exe in Install.pm, no? $target is
> > normally an absolute path per the call of Install().
>
> Attached is the patch I have in mind. After more investigation zic.exe
> is indeed broken, $target can be a full path, and if it contains a
> space things blow up. The commands of vcregress upgradecheck need a
> cleanup as well. I have merged both patches together and the part for
> src/tools/msvc needs a backpatch. Separating both things is trivial
> anyway as the MSVC and the TAP stuff are on two completely separate
> paths.

Agreed. Grep'ing "system" in the source tree, I see no more place
where needs the same fix.

regards,

--
Kyotaro Horiguchi
NTT Open Source Software Center