[CF2016-9] Allow spaces in working path on tap-tests

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: pgsql-hackers(at)postgresql(dot)org
Subject: [CF2016-9] Allow spaces in working path on tap-tests
Date: 2016-07-04 07:02:13
Message-ID: 20160704.160213.111134711.horiguchi.kyotaro@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hello, this is just an entry mail for the next CF.

The tap-test fails when the soruce directoy containing spaces. I
accidentially hit this by a Jenkins project with the name "test

The function system_log() is safe for such parameters but
backup() uses it in wrong way. On the other hand,
enable_restoring() and enable_archiving() forgets to quote such a
path containing spaces as already done for Windows. I don't see
the similar problem in other places.

Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
0001-Allow-spaces-in-working-directory-path-on-TAP-tests.patch text/x-patch 1.4 KB


Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2016-07-04 07:15:55 Renaming more clearly SHA functions in pgcrypto/
Previous Message Kyotaro HORIGUCHI 2016-07-04 06:04:05 Re: An extra error for client disconnection on Windows