Re: dumping database privileges broken in 9.6

* Robert Haas (robertmhaas(at)gmail(dot)com) wrote:
> On Tue, Jun 28, 2016 at 11:12 PM, Peter Eisentraut
> <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> > Do this:
> >
> > CREATE DATABASE test1;
> > REVOKE CONNECT ON DATABASE test1 FROM PUBLIC;
> >
> > Run pg_dumpall.
> >
> > In 9.5, this produces
> >
> > CREATE DATABASE test1 WITH TEMPLATE = template0 OWNER = peter;
> > REVOKE ALL ON DATABASE test1 FROM PUBLIC;
> > REVOKE ALL ON DATABASE test1 FROM peter;
> > GRANT ALL ON DATABASE test1 TO peter;
> > GRANT TEMPORARY ON DATABASE test1 TO PUBLIC;
> >
> > In 9.6, this produces only
> >
> > CREATE DATABASE test1 WITH TEMPLATE = template0 OWNER = peter;
> > GRANT TEMPORARY ON DATABASE test1 TO PUBLIC;
> > GRANT ALL ON DATABASE test1 TO peter;
> >
> > Note that the REVOKE statements are missing. This does not correctly
> > recreate the original state.
>
> If I were a betting man, I'd bet that one of Stephen Frost's pg_dump
> commits broke this. But we'd have to bisect to be sure.

Wouldn't be too surprising. I'm planning to look into this a bit later
today.

Thanks!

Stephen