Re: increase message string buffer size of watch command of psql

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Ioseph Kim <pgsql-kr(at)postgresql(dot)kr>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: increase message string buffer size of watch command of psql
Date: 2016-06-15 20:38:03
Message-ID: 20160615203803.GA25616@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> I wrote:

> > Well, we did part of that, but it's still using asctime(). Should we
> > change that to strftime(..."%c"...) to be less English-centric?
> > (The result seems to be the same in C locale. pg_controldata has done
> > it that way for a long time, with few complaints.) If we want to do so,
> > now would be the time, since 9.6 already whacked around the format
> > of \watch output.
>
> I take it from the vast silence that nobody particularly cares one way
> or the other. On reflection I think that this would be a good change
> to make, so I'll go do so unless I hear complaints soon.

+1 to strftime("%c"). If we wanted to provide additional flexibility we
could have a \pset option to change the strftime format string to
something other than %c, but I don't think there's enough demand to
justify it.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2016-06-15 20:59:30 Re: parallel.c is not marked as test covered
Previous Message Andres Freund 2016-06-15 20:25:52 Re: Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold <