Re: Problem with dumping bloom extension

From: Noah Misch <noah(at)leadboat(dot)com>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Thom Brown <thom(at)linux(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Problem with dumping bloom extension
Date: 2016-06-07 05:57:54
Message-ID: 20160607055754.GA773310@tornado.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jun 03, 2016 at 12:31:44PM -0400, Stephen Frost wrote:
> * Michael Paquier (michael(dot)paquier(at)gmail(dot)com) wrote:
> > On Fri, Jun 3, 2016 at 8:57 PM, Thom Brown <thom(at)linux(dot)com> wrote:
> > > If a database with the bloom extension installed is dumped and restored,
> > > there's an error with the access method creation:
> > >
> > > createdb bloomtest
> > > psql -c 'CREATE EXTENSION bloom;' bloomtest
> > > pg_dump -d bloomtest > ~/tmp/bloom.sql
> > > createdb bloomtest2
> > > psql -d bloomtest2 -f ~/tmp/bloom.sql
> > >
> > > The output of the last command produces:
> > >
> > > "psql:/home/thom/tmp/bloom.sql:48: ERROR: access method "bloom" already
> > > exists"
> > >
> > > So pg_dump shouldn't be dumping this access method as it's part of the
> > > extension.
> >
> > Stephen, something is smelling wrong in checkExtensionMembership()
> > since 5d58999, an access method does not have ACLs and I would have
> > expected that when this routine is invoked in
> > selectDumpableAccessMethod() the object is not selected as dumpable.
>
> Yeah, I saw this also and was going to look into it.

[Action required within 72 hours. This is a generic notification.]

The above-described topic is currently a PostgreSQL 9.6 open item. Stephen,
since you committed the patch believed to have created it, you own this open
item. If some other commit is more relevant or if this does not belong as a
9.6 open item, please let us know. Otherwise, please observe the policy on
open item ownership[1] and send a status update within 72 hours of this
message. Include a date for your subsequent status update. Testers may
discover new open items at any time, and I want to plan to get them all fixed
well in advance of shipping 9.6rc1. Consequently, I will appreciate your
efforts toward speedy resolution. Thanks.

[1] http://www.postgresql.org/message-id/20160527025039.GA447393@tornado.leadboat.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2016-06-07 06:01:09 Re: Typos/Questions in bloom documentation
Previous Message Michael Paquier 2016-06-07 05:46:16 Re: Problem with dumping bloom extension