| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)heroku(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Fix assorted missing infrastructure for ON CONFLICT. |
| Date: | 2016-05-11 20:54:59 |
| Message-ID: | 20160511205459.GA711110@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Peter Geoghegan wrote:
> On Wed, May 11, 2016 at 1:20 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Fix assorted missing infrastructure for ON CONFLICT.
>
> What does this mean?
>
> + /* XXX broken */
> if (attno < 0)
> elog(ERROR, "system column in index");
My guess is that it means we do support indexes in system columns (oid
in particular) and that instead of an ugly error this should do
something else. Maybe silently ignore the index.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2016-05-11 21:00:35 | Re: pgsql: Fix assorted missing infrastructure for ON CONFLICT. |
| Previous Message | Peter Geoghegan | 2016-05-11 20:49:52 | Re: pgsql: Fix assorted missing infrastructure for ON CONFLICT. |