Re: pg_dump dump catalog ACLs

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Noah Misch <noah(at)leadboat(dot)com>, Jose Luis Tallon <jltallon(at)adv-solutions(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_dump dump catalog ACLs
Date: 2016-05-10 20:41:55
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


* Alvaro Herrera (alvherre(at)2ndquadrant(dot)com) wrote:
> The subquery comparing the OID of pg_class using only a condition on
> relname seems wrong; wouldn't it fail or produce wrong results if
> somebody creates a table named pg_class in another schema? I think you
> should write the comparison like this instead:
> classoid = 'pg_catalog.pg_class'::regclass

Thanks, patch attached which does that (qualifying to the same level as
the surrounding query for each).

I've run it through my tests and will plan to push it tomorrow.



Attachment Content-Type Size
qualify_dumpTable_query_v2.patch text/x-diff 7.1 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2016-05-10 20:57:32 Re: asynchronous and vectorized execution
Previous Message Jeff Janes 2016-05-10 20:17:52 Re: HeapTupleSatisfiesToast() busted? (was atomic pin/unpin causing errors)