Re: Default Roles

* Robert Haas (robertmhaas(at)gmail(dot)com) wrote:
> On Sun, Apr 17, 2016 at 11:05 PM, Noah Misch <noah(at)leadboat(dot)com> wrote:
> > On Sun, Apr 17, 2016 at 08:04:03PM -0400, Noah Misch wrote:
> >> On Thu, Apr 07, 2016 at 03:50:47PM -0400, Stephen Frost wrote:
> >> > I'm planning to continue going over the patch tomorrow morning with
> >> > plans to push this before the feature freeze deadline.
> >>
> >> > --- a/src/test/regress/expected/rolenames.out
> >> > +++ b/src/test/regress/expected/rolenames.out
> >>
> >> > +GRANT testrol0 TO pg_abc; -- error
> >> > +ERROR: role "pg_abc" is reserved
> >> > +DETAIL: Cannot GRANT roles to a reserved role.
> >>
> >> The server still accepts "ALTER ROLE testrol0 USER pg_signal_backend". It
> >> should block this ALTER ROLE if it blocks the corresponding GRANT.
> >
> > One more thing:
> >
> >> --- a/src/bin/pg_dump/pg_dumpall.c
> >> +++ b/src/bin/pg_dump/pg_dumpall.c
> >> @@ -665,7 +665,7 @@ dumpRoles(PGconn *conn)
> >> int i;
> >>
> >> /* note: rolconfig is dumped later */
> >> - if (server_version >= 90500)
> >> + if (server_version >= 90600)
> >
> > This need distinct branches for 9.5 and for 9.6+. Today's code would treat a
> > 9.5 cluster like a 9.1 cluster and fail to dump rolbypassrls attributes.
>
> Stephen, did something in today's pile o' commits fix this? If so, which one?

No. I had it in my list but missed it while being anxious about getting
the other patches pushed.

I'll push the fix shortly.

Thanks!

Stephen