Re: pgsql: pg_upgrade: Convert old visibility map format to new format.

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Robert Haas <rhaas(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: pg_upgrade: Convert old visibility map format to new format.
Date: 2016-04-27 00:45:01
Message-ID: 20160427004501.GF13058@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Fri, Mar 11, 2016 at 05:36:34PM +0000, Robert Haas wrote:
> pg_upgrade: Convert old visibility map format to new format.
>
> Commit a892234f830e832110f63fc0a2afce2fb21d1584 added a second bit per
> page to the visibility map, but pg_upgrade has been unaware of it up
> until now. Therefore, a pg_upgrade from an earlier major release of
> PostgreSQL to any commit preceding this one and following the one
> mentioned above would result in invalid visibility map contents on the
> new cluster, very possibly leading to data corruption. This plugs
> that hole.
>
> Masahiko Sawada, reviewed by Jeff Janes, Bruce Momjian, Simon Riggs,
> Michael Paquier, Andres Freund, me, and others.

I have tested the current git trees of all supported versions of
Postgres in all possible pg_upgrade combinations and they all worked
perfectly.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2016-04-27 01:00:38 Re: [COMMITTERS] pgsql: pg_upgrade: Convert old visibility map format to new format.
Previous Message Tom Lane 2016-04-26 22:52:54 pgsql: Add a --brief option to git_changelog.

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2016-04-27 00:48:46 Re: Timeline following for logical slots
Previous Message Robert Haas 2016-04-27 00:37:28 Re: EXPLAIN VERBOSE with parallel Aggregate