From: | Noah Misch <noah(at)leadboat(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees. |
Date: | 2016-04-19 04:16:31 |
Message-ID: | 20160419041631.GC1983345@tornado.leadboat.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Mon, Apr 18, 2016 at 11:56:55PM -0400, Tom Lane wrote:
> Noah Misch <noah(at)leadboat(dot)com> writes:
> > On Mon, Apr 18, 2016 at 10:22:59PM -0400, Tom Lane wrote:
> >> We could alternatively set extra_float_digits to its max value and hope
> >> that off-by-one-in-the-last-place values would get printed as something
> >> visibly different from the exact result. I'm not sure I want to trust
> >> that that works reliably; but maybe it would be worth printing the
> >> result both ways, just to provide additional info when there's a failure.
>
> > We'd have an independent problem if extra_float_digits=3 prints the same
> > digits for distinguishable float values, so I wouldn't mind relying on it not
> > to do that. But can we expect the extra_float_digits=3 representation of
> > those particular values to be the same for every implementation?
>
> Hm? The expected answer is exact (30, 45, or whatever) in each case.
> If we get some residual low-order digits then it's a failure, so we don't
> need to worry about whether it's the same failure everywhere.
Does something forbid snprintf implementations from printing '45'::float8 as
45.0000000000000001 under extra_float_digits=3?
From | Date | Subject | |
---|---|---|---|
Next Message | Dean Rasheed | 2016-04-19 08:03:41 | Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees. |
Previous Message | Tom Lane | 2016-04-19 03:56:55 | Re: [COMMITTERS] pgsql: Add trigonometric functions that work in degrees. |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2016-04-19 04:59:03 | Re: Optimization for updating foreign tables in Postgres FDW |
Previous Message | Etsuro Fujita | 2016-04-19 04:14:02 | Re: Optimization for updating foreign tables in Postgres FDW |