Re: [COMMITTERS] pgsql: Add new catalog called pg_init_privs

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Add new catalog called pg_init_privs
Date: 2016-04-15 19:27:37
Message-ID: 20160415192737.GG10850@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

* Alvaro Herrera (alvherre(at)2ndquadrant(dot)com) wrote:
> Stephen Frost wrote:
> > Alvaro,
>
> > Will take a look at this, though I'm just about to commit a fix that's
> > probably related (and addresses Pavel's issue). Basically, for reasons
> > unknown, I was calling systable_endscan() immediately after
> > systable_getnext(), which doesn't work when you want to use the tuple
> > you got back.
>
> Yeah, I noticed that bug too. It might well explain the issue, because
> the tuple is seen as 0x7f.
>
> #0 heap_deform_tuple (tuple=tuple(at)entry=0x339f438, tupleDesc=tupleDesc(at)entry=0x7f680f3dcde0,
> values=values(at)entry=0x3390cd8,
> isnull=isnull(at)entry=0x339f3c8 "\177\177\177\177\177~\177\177h\367\071\003")
> at /pgsql/source/master/src/backend/access/common/heaptuple.c:881
> #1 0x0000000000479e3a in heap_modify_tuple (tuple=tuple(at)entry=0x339f438, tupleDesc=0x7f680f3dcde0,
> replValues=replValues(at)entry=0x7ffd662a3770, replIsnull=replIsnull(at)entry=0x7ffd662a3750 "",
> doReplace=doReplace(at)entry=0x7ffd662a3760 "")
> at /pgsql/source/master/src/backend/access/common/heaptuple.c:817
> #2 0x0000000000518feb in recordExtensionInitPriv (objoid=46960, classoid=2615, objsubid=0,
> new_acl=0x339f188) at /pgsql/source/master/src/backend/catalog/aclchk.c:5305
> #3 0x000000000051d2b5 in ExecGrant_Namespace (istmt=<optimized out>)
> at /pgsql/source/master/src/backend/catalog/aclchk.c:2942
>
> Not sure what "Pavel's issue" is, since it's not listed in the open
> items page.

Here's the latest message ID on the thread he started.

CAFj8pRB_8WggxG1EKgfDQ_G_C1p1iLC_j9M3JfLfMLd2Vxt_+w(at)mail(dot)gmail(dot)com

Pretty sure it's the same issue. Going through testing now and will
push the fix very shortly.

Thanks!

Stephen

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-04-15 20:49:58 pgsql: Sync 9.2 and 9.3 versions of barrier.h with 9.4's version.
Previous Message Alvaro Herrera 2016-04-15 19:26:08 Re: [COMMITTERS] pgsql: Add new catalog called pg_init_privs

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2016-04-15 20:15:37 Re: more parallel query documentation
Previous Message Tom Lane 2016-04-15 19:26:17 Re: Suspicious behaviour on applying XLOG_HEAP2_VISIBLE.