Re: [COMMITTERS] pgsql: Add new catalog called pg_init_privs

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Add new catalog called pg_init_privs
Date: 2016-04-15 19:20:57
Message-ID: 20160415192057.GE10850@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Alvaro,

* Alvaro Herrera (alvherre(at)2ndquadrant(dot)com) wrote:
> Stephen Frost wrote:
> > Add new catalog called pg_init_privs
> >
> > This new catalog holds the privileges which the system was
> > initialized with at initdb time, along with any permissions set
> > by extensions at CREATE EXTENSION time. This allows pg_dump
> > (and any other similar use-cases) to detect when the privileges
> > set on initdb-created or extension-created objects have been
> > changed from what they were set to at initdb/extension-creation
> > time and handle those changes appropriately.
>
> If you have an extension that's marked not relocatable and drop it, its
> schema is left behind; trying to create the extension again, *crash*.

Will take a look at this, though I'm just about to commit a fix that's
probably related (and addresses Pavel's issue). Basically, for reasons
unknown, I was calling systable_endscan() immediately after
systable_getnext(), which doesn't work when you want to use the tuple
you got back.

Thanks!

Stephen

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2016-04-15 19:26:08 Re: [COMMITTERS] pgsql: Add new catalog called pg_init_privs
Previous Message Alvaro Herrera 2016-04-15 19:18:36 Re: [COMMITTERS] pgsql: Add new catalog called pg_init_privs

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2016-04-15 19:26:08 Re: [COMMITTERS] pgsql: Add new catalog called pg_init_privs
Previous Message Alvaro Herrera 2016-04-15 19:18:36 Re: [COMMITTERS] pgsql: Add new catalog called pg_init_privs