| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Allow Pin/UnpinBuffer to operate in a lockfree manner. |
| Date: | 2016-04-12 05:00:38 |
| Message-ID: | 20160412050038.ua2avkwi6dxxcjhx@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2016-04-12 00:32:13 -0400, Tom Lane wrote:
> I wrote:
> > This commit has broken buildfarm member gaur, and no doubt pademelon
> > will be equally unhappy once it catches up to HEAD.
>
> Spoke too soon, actually: pademelon did not get as far as initdb.
>
> cc: "bufmgr.c", line 4032: error 1521: Incorrect initialization.
> cc: "bufmgr.c", line 4058: error 1521: Incorrect initialization.
>
> Apparently, assigning the result of init_spin_delay() is not as portable
> as you thought.
Hm. I'm not sure why not though? Is it because delayStatus isn't static
or global scope?
> Maybe convert that into init_spin_delay(SpinDelayStatus *target,
> whatever-the-other-arg-is) ?
Too bad, my compiler generates a bit nicer code for the current version.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2016-04-12 08:18:21 | Re: [COMMITTERS] pgsql: Code cleanup in the wake of recent LWLock refactoring. |
| Previous Message | Tom Lane | 2016-04-12 04:32:13 | Re: [COMMITTERS] pgsql: Allow Pin/UnpinBuffer to operate in a lockfree manner. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-04-12 05:10:31 | Re: Parser extensions (maybe for 10?) |
| Previous Message | Tsunakawa, Takayuki | 2016-04-12 04:58:05 | Re: Parser extensions (maybe for 10?) |