Re: the buildfarm has measles

Robert Haas wrote:

> woodlouse and thrips failed like this (and mastodon in a similar but
> not identical way):
>
> "C:\buildfarm\buildenv\HEAD\pgsql.build\pgsql.sln" (Standardziel) (1) ->
> "C:\buildfarm\buildenv\HEAD\pgsql.build\ascii_and_mic.vcxproj"
> (Standardziel) (2) ->
> "C:\buildfarm\buildenv\HEAD\pgsql.build\postgres.vcxproj" (Standardziel) (3) ->
> (ClCompile Ziel) ->
> src/backend/access/brin/brin_pageops.c(824): error C2026: string too
> big, trailing characters truncated
> [C:\buildfarm\buildenv\HEAD\pgsql.build\postgres.vcxproj]

This complaint refers to this line:

Assert(BRIN_IS_REGULAR_PAGE(BufferGetPage(oldbuf, NULL, NULL,
BGP_NO_SNAPSHOT_TEST)));

which the compiler complains that gets too long. This is related:
https://www.postgresql.org/message-id/4407.1435763473%40sss.pgh.pa.us
(There's a patch there which was never pushed AFAICS).

I suggest that we fix this by making BufferGetPage an inline function
rather than a macro.

> crake failed 'make check':
>
> *** /home/bf/bfr/root/HEAD/pgsql.build/src/test/regress/expected/misc.out
> Fri Apr 8 19:38:58 2016
> --- /home/bf/bfr/root/HEAD/pgsql.build/src/test/regress/results/misc.out
> Fri Apr 8 19:39:12 2016
> ***************
> *** 607,612 ****
> --- 607,613 ----
> circle_tbl
> city
> copy_tbl
> + ctv_data
> d
> d_star
> date_tbl

Ahh, my bug -- this is because test psql, in the same parallel group as
misc, creates this table. I hesitate to move the whole test to another
group; perhaps it's better to split the crosstabview out to its own
file, as Daniel had submitted it.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services