Re: skink vs. phrase full text search

Hi,

On 2016-04-08 10:45:01 -0400, Tom Lane wrote:
> Buildfarm member skink has been unhappy since bb14050 went in,
> but I find that I cannot reproduce any failure by valgrind'ing
> here. Can you suggest any secret sauce that that animal may
> be using?

I gather you're compiling with USE_VALGRIND enabled? Valgrind - from svn
- is run with postgres replaced via

+sub replace_postgres
+{
+ my $srcdir=$use_vpath ? "../pgsql/" : ".";
+ my $builddir=abs_path("$pgsql");
+ $srcdir=abs_path("$pgsql/$srcdir");
+ chdir "$pgsql/src/backend/";
+ rename "postgres", "postgres.orig";
+ sysopen my $fh, "postgres", O_CREAT|O_TRUNC|O_RDWR, 0700
+ or die "Could not create postgres wrapper";
+ print $fh <<"END";
+#!/bin/bash
+exec /usr/local/bin/valgrind \\
+ --quiet \\
+ --error-exitcode=128 \\
+ --suppressions=$srcdir/src/tools/valgrind.supp \\
+ --trace-children=yes --track-origins=yes --read-var-info=yes \\
+ --leak-check=no \\
+ --error-markers=VALGRINDERROR-BEGIN,VALGRINDERROR-END \\
+ $builddir/src/backend/postgres.orig \\
+ "\$@"
+END
+ close $fh;
+ chdir $branch_root;
+}
+

but the options ( --trace-children=yes --track-origins=yes
--read-var-info=yes --error-exitcode=128 --leak-check=no) shouln't be
too exotic.

The cflags I use are:
CPPFLAGS => '-DUSE_VALGRIND',
CFLAGS => '-Og -ggdb -g3 -Wall -Wextra -Wno-unused-parameter -Wno-sign-compare -Wno-missing-field-initializers -fno-omit-frame-pointer'

If you can't reproduce I can look into it, but it's unlikely going to be
today...

Greetings,

Andres Freund