Re: [COMMITTERS] pgsql: In pg_dump, include pg_catalog and extension ACLs, if changed

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [COMMITTERS] pgsql: In pg_dump, include pg_catalog and extension ACLs, if changed
Date: 2016-04-07 17:38:24
Message-ID: 20160407173824.GK10850@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Tom,

* Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> It'd be possible to fix (1) by adding "drop if exists", but I think the
> whole thing is wrongheaded due to (2). Perhaps the needs of the test
> could be met by granting/revoking some rights explicitly to current_user
> (ie, the test superuser)? That wouldn't have any real effects on a
> superuser, but it would provide some grist for testing the behavior.

Sure, I can do that.

> Or you could test this behavior in some other setting than the core
> regression tests; perhaps in a TAP test for pg_dump.

I have to admit that I'm not terrible familiar with setting that up, but
will take a look at it. This is what I'd really like to have as we
have far too little testing of pg_dump in the test suite.

Thanks!

Stephen

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Teodor Sigaev 2016-04-07 17:47:27 pgsql: Zeroing unused parts ducring tsquery construction.
Previous Message Tom Lane 2016-04-07 17:30:31 Re: [COMMITTERS] pgsql: In pg_dump, include pg_catalog and extension ACLs, if changed

Browse pgsql-hackers by date

  From Date Subject
Next Message Petr Jelinek 2016-04-07 17:53:56 Re: Proposal: Generic WAL logical messages
Previous Message Tom Lane 2016-04-07 17:30:31 Re: [COMMITTERS] pgsql: In pg_dump, include pg_catalog and extension ACLs, if changed