Re: Patch to implement pg_current_logfile() function

From: "Karl O(dot) Pinc" <kop(at)meme(dot)com>
To: Gilles Darold <gilles(dot)darold(at)dalibo(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Shulgin, Oleksandr" <oleksandr(dot)shulgin(at)zalando(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch to implement pg_current_logfile() function
Date: 2016-04-07 06:30:30
Message-ID: 20160407013030.3a2d7aae@slate.meme.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 7 Apr 2016 01:13:51 -0500
"Karl O. Pinc" <kop(at)meme(dot)com> wrote:

> On Wed, 6 Apr 2016 23:37:09 -0500
> "Karl O. Pinc" <kop(at)meme(dot)com> wrote:
>
> > On Wed, 6 Apr 2016 22:26:13 -0500
> > "Karl O. Pinc" <kop(at)meme(dot)com> wrote:
> > > On Wed, 23 Mar 2016 23:22:26 +0100
> > > Gilles Darold <gilles(dot)darold(at)dalibo(dot)com> wrote:
> > >
> > > > Thanks for the reminder, here is the v3 of the patch after a
> > > > deeper review and testing. It is now registered to the next
> > > > commit fest under the System Administration topic.

> This is what I see at the moment. I'll wait for replies
> before looking further and writing more.

Er, one more thing. Isn't it true that in logfile_rotate()
you only need to call store_current_log_filename() when
logfile_open() is called with a "w" mode, and never need to
call it when logfile_open() is called with an "a" mode?

Karl <kop(at)meme(dot)com>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2016-04-07 06:34:01 Re: Support for N synchronous standby servers - take 2
Previous Message Michael Paquier 2016-04-07 06:29:13 Re: Speedup twophase transactions