Re: show xl_prev in xlog.c errcontext

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: hlinnaka(at)iki(dot)fi, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: show xl_prev in xlog.c errcontext
Date: 2016-04-04 21:14:40
Message-ID: 20160404211440.GA236605@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Michael Paquier wrote:
> On Thu, Apr 16, 2015 at 3:25 PM, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
> > On 04/15/2015 11:35 PM, Alvaro Herrera wrote:
> >>
> >> I found this patch in my local repo that I wrote some weeks or months
> >> ago while debugging some XLog corruption problem: it was difficult to
> >> pinpoint what XLog record in a long sequence of WAL files was causing a
> >> problem, and the displaying the prev pointer in errcontext made finding
> >> it much easier -- I could correlate it with pg_xlogdump output, I think.
> >
> > Seems like a good idea, but why print the prev pointer, and not the location
> > of the record itself?

Makes sense -- pushed that way.

> And both?

I couldn't see much point of doing this, so I didn't. If you have a
rationale for it, let's hear it.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Petr Jelinek 2016-04-04 21:38:27 Re: Timeline following for logical slots
Previous Message Oleksii Kliukin 2016-04-04 20:19:32 Re: WIP: Failover Slots