From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Simon Riggs <simon(at)2ndQuadrant(dot)com> |
Cc: | pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
Subject: | Re: pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server |
Date: | 2016-04-04 06:42:02 |
Message-ID: | 20160404064202.GE2431@awork2.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On 2016-04-04 07:31:46 +0100, Simon Riggs wrote:
> On 4 April 2016 at 07:24, Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> > On 2016-04-04 06:19:04 +0000, Simon Riggs wrote:
> > > Avoid archiving XLOG_RUNNING_XACTS on idle server
> > >
> > > If archive_timeout > 0 we should avoid logging XLOG_RUNNING_XACTS if
> > idle.
> > >
> > > Bug 13685 reported by Laurence Rowe, investigated in detail by Michael
> > Paquier,
> > > though this is not his proposed fix.
> > > 20151016203031(dot)3019(dot)72930(at)wrigleys(dot)postgresql(dot)org
> > >
> > > Simple non-invasive patch to allow later backpatch to 9.4 and 9.5
> >
> > Uh. This is wrong.
>
>
> For one it breaks cleanup with logical decoding which
> > does *NEED* to know that nothing is happening. Although only once, not
> > repeatedly.
> >
>
> If the patch did that, I agree it would be wrong. It doesn't,
> deliberately.
It doesn't?
+ if (running->xcnt == 0 &&
+ nlocks == 0 &&
+ XLogArchiveTimeout > 0 &&
+ !last_snapshot_overflowed)
+ {
+ LWLockRelease(XidGenLock);
+ return InvalidXLogRecPtr;
+ }
Overflowed snapshots aren't a problem for logical decoding. But we need
to know that no old transactions are running occasionally.
Andres
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2016-04-04 06:49:20 | Re: pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server |
Previous Message | Simon Riggs | 2016-04-04 06:31:46 | Re: pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server |
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2016-04-04 06:43:45 | Re: Timeline following for logical slots |
Previous Message | Andres Freund | 2016-04-04 06:39:17 | Re: Timeline following for logical slots |