Re: pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server

From: Andres Freund <andres(at)anarazel(dot)de>
To: Simon Riggs <simon(at)2ndQuadrant(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server
Date: 2016-04-04 06:24:50
Message-ID: 20160404062450.GB2431@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2016-04-04 06:19:04 +0000, Simon Riggs wrote:
> Avoid archiving XLOG_RUNNING_XACTS on idle server
>
> If archive_timeout > 0 we should avoid logging XLOG_RUNNING_XACTS if idle.
>
> Bug 13685 reported by Laurence Rowe, investigated in detail by Michael Paquier,
> though this is not his proposed fix.
> 20151016203031(dot)3019(dot)72930(at)wrigleys(dot)postgresql(dot)org
>
> Simple non-invasive patch to allow later backpatch to 9.4 and 9.5

Uh. This is wrong. For one it breaks cleanup with logical decoding which
does *NEED* to know that nothing is happening. Although only once, not repeatedly.

Andres

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2016-04-04 06:27:46 Re: pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server
Previous Message Simon Riggs 2016-04-04 06:19:04 pgsql: Avoid archiving XLOG_RUNNING_XACTS on idle server

Browse pgsql-hackers by date

  From Date Subject
Next Message Craig Ringer 2016-04-04 06:24:52 Re: Timeline following for logical slots
Previous Message Michael Paquier 2016-04-04 06:22:22 Re: Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby