Re: pgbench - remove unused clientDone parameter

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Fabien <coelho(at)cri(dot)ensmp(dot)fr>
Cc: PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgbench - remove unused clientDone parameter
Date: 2016-04-01 20:13:18
Message-ID: 20160401201318.GA83554@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Fabien wrote:
> Remove pgbench clientDone unused "ok" parameter.

Seems useless, yeah, removed.

> I cannot get the point of keeping a useless parameter, which is probably
> there because at some point in the past it was used. If it is needed some
> day it can always be reinserted.

Actually it was introduced as an unused argument in 3da0dfb4b146. I
don't quite see the reason, I guess they thought it'd become used at
some point. Since it hasn't in the 7 intervening years, it seems safe
to remove it.

Álvaro Herrera
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2016-04-01 20:15:20 Re: Fix handling of invalid sockets returned by PQsocket()
Previous Message Alvaro Herrera 2016-04-01 19:59:48 Re: Re: [COMMITTERS] pgsql: Enable logical slots to follow timeline switches