| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Ian Barwick <ian(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Correction for replication slot creation error message in 9.6 |
| Date: | 2016-03-31 14:18:46 |
| Message-ID: | 20160331141846.GA104951@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund wrote:
> On 2016-03-31 10:15:21 +0900, Ian Barwick wrote:
> > Patch changes the error message to:
> >
> > ERROR: replication slots can only be used if wal_level is "replica" or "logical"
> >
> > Explicitly naming the valid WAL levels matches the wording in the wal_level
> > error hint used in a couple of places, i.e.
>
> The explicit naming makes it much more verbose to change anything around
> wal level though, so consider me not a fan of spelling out all levels.
I thought we had agreed that we weren't going to consider the wal_level
values as a linear scale -- in other words, wordings such as "greater
than FOO" are discouraged. That's always seemed a bit odd to me.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2016-03-31 15:29:37 | Re: WIP: Access method extendability |
| Previous Message | Tom Lane | 2016-03-31 14:16:09 | Re: Move PinBuffer and UnpinBuffer to atomics |