| From: | Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Small patch: Change calling convention for ShmemInitHash (and fix possible bug) |
| Date: | 2016-03-24 13:50:45 |
| Message-ID: | 20160324165045.1b4eb1a0@fujitsu |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello
I would like to continue discussion regarding changing calling
convention for ShmemInitHash procedure:
Currently this procedure has two arguments --- init_size and max_size.
But since shared hash tables have fixed size there is little sense to
pass two arguments. In fact currently ShmemInitHash is always called
with init_size == max_size with only one exception, InitLocks procedure
(see lock.c), which I believe is actually a bug.
Patch is attached.
What do you think?
--
Best regards,
Aleksander Alekseev
http://eax.me/
| Attachment | Content-Type | Size |
|---|---|---|
| change-shmem-init-hash-calling-convention.diff | text/x-patch | 5.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Konstantin Knizhnik | 2016-03-24 14:00:55 | avg,first,last,median in one query |
| Previous Message | Masahiko Sawada | 2016-03-24 13:29:01 | Re: Support for N synchronous standby servers - take 2 |