Re: pg_filedump patch for 9.5

From: Christoph Berg <myon(at)debian(dot)org>
To: Pavel Raiskup <praiskup(at)redhat(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, Satoshi Nagayasu <snaga(at)uptime(dot)jp>
Subject: Re: pg_filedump patch for 9.5
Date: 2016-03-19 17:06:14
Message-ID: 20160319170614.GB8052@msg.df7cb.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Re: Pavel Raiskup 2016-02-26 <8883822(dot)6jZMTTXa3b(at)nb(dot)usersys(dot)redhat(dot)com>
> On Saturday 08 of August 2015 20:38:38 Satoshi Nagayasu wrote:
> > I have created a patch for pg_filedump to work with 9.5.
> > Here is a list of changes.
> >
> > * Fix to rename CRC32 macros to work with 9.5.
> > * Fix to add missing DBState: DB_SHUTDOWNED_IN_RECOVERY.
> > * Fix to add missing page flags for Btree and GIN.
> > * Update copyright date.
> >
> > Please take a look. Any comments are welcome.
>
> Thanks for the patch; it helps with building against 9.5.
>
> Hints I can give ATM:
>
> * copyright is outdated now
> * to allow the build with 'make
> PGSQL_INCLUDE_DIR=/usr/include/pgsql/server' the following patch is
> needed:
>
> --- a/Makefile
> +++ b/Makefile
> @@ -18,7 +18,7 @@ DISTFILES= README.pg_filedump Makefile Makefile.contrib \
> all: pg_filedump
>
> pg_filedump: pg_filedump.o
> - ${CC} ${CFLAGS} -o pg_filedump pg_filedump.o
> + ${CC} ${CFLAGS} -o pg_filedump pg_filedump.o -lpgport
>
> Pavel

Hi,

thanks for the patches, I've pushed them to the git repo.

http://git.postgresql.org/gitweb/?p=pg_filedump.git

Christoph

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Christoph Berg 2016-03-19 17:07:31 pg_filedump 9.5.0
Previous Message Fabien COELHO 2016-03-19 16:47:48 Re: incorrect docs for pgbench / skipped transactions