| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>, Peter Geoghegan <pg(at)heroku(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Minor bug affecting ON CONFLICT lock wait log messages |
| Date: | 2016-03-15 15:16:26 |
| Message-ID: | 20160315151626.GA284371@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Stephen Frost wrote:
> * Julien Rouhaud (julien(dot)rouhaud(at)dalibo(dot)com) wrote:
> XLTW_InsertIndexUnique is used when building a unique index, but this is
> just a check, and more to the point, it's actually a re-check of what
> we're doing in nbinsert.c where we're already using XLTW_InsertIndex.
>
> We wouldn't want to end up returning different error messages for the
> same command under the same conditions just based, which is what we'd
> potentially end up doing if we used XLTW_InsertIndexUnique here.
Perhaps we need a new value in that enum, so that the context message is
specific to the situation at hand?
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2016-03-15 15:28:04 | Re: Small patch: fix warnings during compilation on FreeBSD |
| Previous Message | Alvaro Herrera | 2016-03-15 15:11:53 | Re: Speed up Clog Access by increasing CLOG buffers |