Re: Re: In-core regression tests for replication, cascading, archiving, PITR, etc.

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>,Noah Misch <noah(at)leadboat(dot)com>, amir(dot)rohan(at)zoho(dot)com,Robert Haas <robertmhaas(at)gmail(dot)com>, andres(at)2ndquadrant(dot)com,PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>,gsmith(at)gregsmith(dot)com
Subject: Re: Re: In-core regression tests for replication, cascading, archiving, PITR, etc.
Date: 2016-03-01 15:10:12
Message-ID: 20160301151012.GA348137@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Michael Paquier wrote:
> On Tue, Mar 1, 2016 at 5:13 PM, Kyotaro HORIGUCHI
> <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:

> + return wantarray ? ($stdout, $stderr) : $stdout;
> So you are willing to extend that so as you could perform conparison
> tests on the error strings returned. Why no, it looks useful, though
> now there is no test in need of it I think. So without a proper need I
> think that we could live without.

Does this change let us implement psql_ok and psql_fail? I think I've
seen a few places already, both in committed code and in submitted
patches, that test for some kind of failure from psql.

> > 0002-Prefix-test-numbers-to-node-
> >
> > This is rather a example usage of 0001- patch (except for
> > stderr stuff). 00n_xxx test leaves temporary directories with
> > the names of 00n_(master|standby)_XXXX on failure. If this is
> > considered reasonable, I'll make same patches for the other
> > /t/nnn_*.pl tests.
>
> -my $node_master = get_new_node('master');
> +my $node_master = get_new_node('001_master');
> I am not a fan of appending the test number in the node name. For one,
> this complicates the log file name associated with a node by
> duplicating the test number in its name. Also, it is possible to
> easily get the name of the data folder for a node by looking at the
> logs.

Why don't we use something similar to what's in $test_logfile in
TestLib?

> Also, it is possible to easily get the name of the data folder for a
> node by looking at the logs.

No disagreement on it being possible, but "easily" seems a bad
description for that.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2016-03-01 15:12:28 Re: Addition of extra commit fest entry to park future patches
Previous Message Teodor Sigaev 2016-03-01 15:09:16 Re: WIP: Upper planner pathification