Fixing wrong comment on PQmblen and PQdsplen.

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Fixing wrong comment on PQmblen and PQdsplen.
Date: 2016-02-26 05:33:41
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


I divided the last patch into one typo-fix patch and one
improvement patch. This is the former one.

At Fri, 06 Nov 2015 11:47:17 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote in <20151106(dot)114717(dot)170526268(dot)horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
> > Just a minor nitpick -
> >
> > ... character beginning *at* s ...?
> >
> > If so, there would be one more instance to fix.
> I think so. I overlooked both of them. And as you mention,
> PQdsplen has the same kind of typo. It returns display length of
> the *character* beginning *at* s, too.

This patch fixes wrong comments of PQmblen() and PQdsplen(). The
comments say that "returns the length of the word beginning s"
but what it actually does is "returns the length of the
*character* beginning at s".



Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
0001-Fix-wrong-comments-for-PQmblen-and-PQdsplen.patch text/x-patch 1.1 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2016-02-26 05:34:03 Re: psql completion for ids in multibyte string
Previous Message Craig Ringer 2016-02-26 04:47:52 Re: [REVIEW] In-core regression tests for replication, cascading, archiving, PITR, etc.