| From: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | sawada(dot)mshk(at)gmail(dot)com |
| Cc: | masao(dot)fujii(at)gmail(dot)com, michael(dot)paquier(at)gmail(dot)com, robertmhaas(at)gmail(dot)com, thom(at)linux(dot)com, thomas(dot)munro(at)enterprisedb(dot)com, memissemerson(at)gmail(dot)com, josh(at)agliodbs(dot)com, amit(dot)kapila16(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Support for N synchronous standby servers - take 2 |
| Date: | 2016-02-26 01:38:22 |
| Message-ID: | 20160226.103822.12680005.horiguchi.kyotaro@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello, Thanks for the new patch.
At Fri, 26 Feb 2016 08:52:54 +0900, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote in <CAD21AoAZKFVu8-MVhkJ3ywAiJmb=P-HSbJTGi=gK1La73KjS6Q(at)mail(dot)gmail(dot)com>
> Previous patch could not parse one character standby name correctly.
> Attached latest patch.
I haven't looked it in detail but it won't work as you
expected. flex compains as the following for v12 patch.
syncgroup_scanner.l:80: warning, rule cannot be matched
syncgroup_scanner.l:84: warning, rule cannot be matched
They are warnings about the patterns [1-9][0-9]* and {asterisk}
because it is matched by {node_name}+. The latter would no harm
(or the pattern is useless) but the former will make '1[a,b,c]'
to fail.
regards,
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro HORIGUCHI | 2016-02-26 01:53:25 | Re: Support for N synchronous standby servers - take 2 |
| Previous Message | Tomas Vondra | 2016-02-26 00:59:31 | Re: improving GROUP BY estimation |