Re: insufficient qualification of some objects in dump files

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: insufficient qualification of some objects in dump files
Date: 2016-02-04 23:10:33
Message-ID: 20160204231033.GA245431@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut wrote:
> Some dump objects whose names are not unique on a schema level have
> insufficient details in the dump TOC. For example, a column default
> might have a TOC entry like this:
>
> 2153; 2604 39696 DEFAULT public a rolename

> I think we should amend the archive tag for these kinds of objects to
> include the table name, so it might look like:
>
> 2153; 2604 39696 DEFAULT public test a rolename
>
> Comments?

If we're changing anything, I wonder if it makes sense to go for adding
the object identity there. Perhaps that would make the whole thing be a
little more regular, rather than have to count elements depending on
object type. So in this case it'd be

2153; 2604 39696 DEFAULT public.test.a rolename

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andreas Karlsson 2016-02-04 23:22:50 Re: UNIQUE capability to hash indexes
Previous Message David G. Johnston 2016-02-04 23:09:49 Re: "using previous checkpoint record at" maybe not the greatest idea?