Re: Template for commit messages

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Template for commit messages
Date: 2016-01-28 16:31:28
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Thu, Jan 28, 2016 at 10:40:09AM -0500, Stephen Frost wrote:
> * Joshua D. Drake (jd(at)commandprompt(dot)com) wrote:
> > On 01/28/2016 06:57 AM, Robert Haas wrote:
> >
> > >>I'm on board with Bruce's template as being a checklist of points to be
> > >>sure to cover when composing a commit message. I'm not sure we need
> > >>fixed-format rules.
> > >
> > >Well, I think what people are asking for is precisely a fixed format,
> > >and I do think there is value in that. It's nice to capture the
> > >nuance, but the nuance is going to get flattened out anyway when the
> > >release notes are created. If we all agree to use a fixed format,
> > >then a bunch of work there that probably has to be done manually can
> > >be automated. However, if we all agree to use a fixed format except
> > >for you, we might as well just forget the whole thing, because the
> > >percentage of commits that are done by you is quite high.
> >
> > Yes, we are either all in or we may as well forgo this.
> I don't have a particular issue with it, but would like whatever
> template is decided upon to be included in our git repo and then we
> should be able to make it the template that's opened up when people go
> to commit pretty easily.

OK, but keep in mind whatever script committers user should remove tags
that are empty after exiting the editor. I can provide the grep regex
in git somewhere too:

egrep -v "^(Author|Reported-by|Bug|Reviewed-by|Tested-by|Backpatch-through): *$"

Bruce Momjian <bruce(at)momjian(dot)us>

+ As you are, so once was I. As I am, so you will be. +
+ Roman grave inscription +

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2016-01-28 16:37:59 Re: tiny doc patch
Previous Message Robert Haas 2016-01-28 16:28:19 Re: CustomScan under the Gather node?