Re: Some bugs in psql_complete of psql

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: peter_e(at)gmx(dot)net
Cc: masao(dot)fujii(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Some bugs in psql_complete of psql
Date: 2016-01-26 09:33:31
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hello, thank you for committing this.

At Sat, 16 Jan 2016 21:09:26 -0500, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote in <569AF7D6(dot)9090107(at)gmx(dot)net>
> On 1/12/16 9:46 PM, Peter Eisentraut wrote:
> > On 12/22/15 4:44 AM, Kyotaro HORIGUCHI wrote:
> >> 1. 0001-Fix-tab-complete-of-CREATE-INDEX.patch
> >>
> >> Fixes completion for CREATE INDEX in ordinary way.
> >
> > This part has been fixed in another thread. Please check whether that
> > satisfies all your issues.
> >
> >> 3. 0002-Fix-tab-completion-for-DROP-INDEX.patch
> >>
> >> Fix of DROP INDEX completion in the type-2 way.
> >
> > I agree that we could use completion support for DROP INDEX
> > CONCURRENTLY, but I would rather not throw IF NOT EXISTS into the same
> > patch. We don't have support for IF NOT EXISTS anywhere else. If you
> > think about, it's rather unnecessary, because tab completion will
> > determine for you whether an object exists.
> I have applied a reduced version of the DROP INDEX patch. I think that
> covers everything in your submission, but please check.

I examined the commit 4189e3d659abb48d159a6c3faabaa7e99498ca3e
and it looks fine. I'll post another patch for IF (NOT) EXISTS
for all possible part later. Thank you Peter.


Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro HORIGUCHI 2016-01-26 09:51:47 Re: pgbench - allow backslash-continuations in custom scripts
Previous Message Kyotaro HORIGUCHI 2016-01-26 09:23:12 Re: [PoC] Asynchronous execution again (which is not parallel)