| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Tsvector editing functions |
| Date: | 2016-01-18 21:21:03 |
| Message-ID: | 20160118212103.GA132670@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
So, Tomas, Teodor, did you like this new version of the patch?
Stas Kelvich wrote:
> > 7) Some of the functions use intexterm that does not match the function
> > name. I see two such cases - to_tsvector and setweight. Is there a
> > reason for that?
>
> Because sgml compiler wants unique indexterm. Both functions that you
> mentioned use overloading of arguments and have non-unique name.
This sounds wrong. I think what you should really do is use
<indexterm>
<primary>foo</primary>
<secondary>bar</secondary>
</indexterm>
to distinguish the two entries.
It's a bit funny that you reintroduce the "unrecognized weight: %d"
(instead of %c) in tsvector_setweight_by_filter.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-01-18 21:21:35 | Re: plpgsql - DECLARE - cannot to use %TYPE or %ROWTYPE for composite types |
| Previous Message | Igal @ Lucee.org | 2016-01-18 21:11:47 | Re: system mingw not recognized |