Re: pg_dump dumps event triggers and transforms unconditionally

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: pg_dump dumps event triggers and transforms unconditionally
Date: 2016-01-12 20:56:21
Message-ID: 20160112205621.GA863805@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> I noticed $subject while trying to fix the extension membership problem
> Karsten Hilbert complained of last week. I do not think that if I ask
> for a dump of a single table, that should include event triggers.

Ugh, certainly not.

> AFAICT event triggers don't belong to any particular schema, so I'd
> propose that they be dumped only when include_everything is true,
> which is the usual rule for objects that don't belong to any schema.
>
> Transforms have got the same issue, which means that the dump of a
> database containing, eg, hstore_plperl is outright broken: it will
> dump both the extension *and* a CREATE TRANSFORM command. Again, they
> ought to obey the default rules for schema-less objects, which in
> this case is "dump if include_everything and not an extension member".

Sounds reasonable. (I assume this last detailed rule is what applies to
both object types. Surely event triggers can be part of an extension
too.)

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2016-01-12 21:11:00 Re: WIP: Rework access method interface
Previous Message Tom Lane 2016-01-12 20:37:44 pg_dump dumps event triggers and transforms unconditionally