| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fwd: Core dump with nested CREATE TEMP TABLE |
| Date: | 2016-01-03 05:35:56 |
| Message-ID: | 20160103053556.GB3002482@tornado.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jan 02, 2016 at 07:22:13PM -0500, Tom Lane wrote:
> Noah Misch <noah(at)leadboat(dot)com> writes:
> > I am inclined to add an Assert(portal->status != PORTAL_ACTIVE) to emphasize
> > that this is backup only. MarkPortalActive() callers remain responsible for
> > updating the status to something else before relinquishing control.
>
> No, I do not think that would be an improvement. There is no contract
> saying that this must be done earlier, IMO.
Indeed, nobody wrote a contract. The assertion would record what has been the
sole standing practice for eleven years (since commit a393fbf9). It would
prompt discussion if a proposed patch would depart from that practice, and
that is a good thing. Also, every addition of dead code should label that
code to aid future readers.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Erik Rijkers | 2016-01-03 08:26:41 | commitfest html - wrong closing tag |
| Previous Message | Amit Kapila | 2016-01-03 04:33:41 | Re: Some 9.5beta2 backend processes not terminating properly? |