Re: Fwd: Core dump with nested CREATE TEMP TABLE

From: Noah Misch <noah(at)leadboat(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fwd: Core dump with nested CREATE TEMP TABLE
Date: 2016-01-02 00:55:42
Message-ID: 20160102005542.GA2951035@tornado.leadboat.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Sep 03, 2015 at 11:04:11PM -0400, Tom Lane wrote:
> *************** AtSubAbort_Portals(SubTransactionId mySu

> --- 909,966 ----
> {
> Portal portal = hentry->portal;
>
> + /* Was it created in this subtransaction? */
> if (portal->createSubid != mySubid)
> + {
> + /* No, but maybe it was used in this subtransaction? */
> + if (portal->activeSubid == mySubid)
> + {
...
> + if (portal->status == PORTAL_ACTIVE)
> + MarkPortalFailed(portal);

Do you have a test case that reaches this particular MarkPortalFailed() call?
My attempts stumbled over the fact that, before we reach here, each of the
three MarkPortalActive() callers will have already called MarkPortalFailed()
in its PG_CATCH block. ("make check" does not reach this call.)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2016-01-02 02:58:59 Re: buffer README is out of date
Previous Message Simon Riggs 2016-01-02 00:50:15 WIP: Failover Slots