Re: fix log_min_duration_statement logic error

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Rod Taylor <rbt(at)rbt(dot)ca>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: fix log_min_duration_statement logic error
Date: 2003-10-06 06:13:22
Message-ID: 20159.1065420802@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Agreed. elog is the proper place, because then you guarantee that it is
> all on one line. Is that OK? Do we have elogs that we want over
> several lines? Is this something we can do at this stage in beta?

As to the latter: sure. We've already hacked the formatting of the log
output quite a bit since 7.3. Better to hit them with this too now,
than spread the pain over multiple releases.

As to the former: the only thing that seems debatable to me is what to
do about the layout of the new multi-part ereport() messages. I would
be inclined to go for one line per part, viz
ERROR: blah blah blah
DETAIL: blah blah\nblah blah
HINT: blah blah\nblah blah\nblah blah
but perhaps someone would like to argue for somehow collapsing all this
to one line? If so, how exactly?

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Peter Eisentraut 2003-10-06 06:20:24 Re: spanish translation updates
Previous Message Tom Lane 2003-10-06 03:48:26 Re: Open 7.4 items