Re: Check for interrupts in bf and xdes crypt()

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
Cc: Andreas Karlsson <andreas(at)proxel(dot)se>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Check for interrupts in bf and xdes crypt()
Date: 2015-12-27 16:05:20
Message-ID: 20151227160520.GD58441@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Jeff Janes wrote:
> On Tue, Dec 15, 2015 at 12:35 AM, Andreas Karlsson <andreas(at)proxel(dot)se> wrote:

> > Here is a patch which makes it possible to cancel a query which runs the
> > crypt() function with the bf or xdes hashing algorithm, e.g. crypt('foo',
> > gen_salt('bf', 13)). The md5 algorithm does not run for multiple rounds so
> > there is no reason to patch it.

> Looks good to me. Applies, builds, passes make check, does what it
> says and says what it does. No need for docs, no noticeable
> performance impact.
> I've marked it ready for committer. Also recommend for back-patching.

Pushed, thanks.

Álvaro Herrera
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Grzegorz Sampolski 2015-12-27 16:31:56 Re: pam auth - add rhost item
Previous Message Jeff Janes 2015-12-27 15:50:47 Avoid endless futile table locks in vacuuming.